[GitHub] [pinot] mcvsubbu commented on pull request #10892: [Draft] Skip Zk Call in Segment Post Commit Phase

["mcvsubbu (via GitHub)" <gi...@apache.org>]

mcvsubbu commented on PR #10892:
URL: https://github.com/apache/pinot/pull/10892#issuecomment-1595473885

   > Before actually fixing this issue, I want to discuss should we allow committing segment during the gracefully shutdown period? We need a clear cutting point beyond which there should be no commit allowed. When we invoke the cutting point method, existing commit can go through, but no new commit will be accepted. The method can be blocked until the ongoing commit finishes. Then we can safely disconnect from Helix.
   
   +1
   
   The protocol handles the case where the commit does not succeed. The servers try again, with other (or the newly restarted) controller to complete the segment. And, the segment is _not_ rebuilt in the servers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org