[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2447: [KYUUBI #2445] Implement ApplicationManager and Yarn/ JPS-local Application Operation

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #2447:
URL: https://github.com/apache/incubator-kyuubi/pull/2447#discussion_r856882720


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -43,12 +43,14 @@ class BatchJobSubmission(session: KyuubiBatchSessionImpl, batchRequest: BatchReq
 
   private lazy val _operationLog = OperationLog.createOperationLog(session, getHandle)
 
-  private var builder: ProcBuilder = _
+  private val applicationManager =
+    session.sessionManager.asInstanceOf[KyuubiSessionManager].applicationManager
 
-  @volatile
-  private[kyuubi] var appIdAndUrl: Option[(String, String)] = None
+  private var builder: ProcBuilder = _
 
-  private var resultFetched: Boolean = _
+  private[kyuubi] def currentApplicationState: Option[Map[String, String]] = {
+    applicationManager.getApplicationInfo(builder.clusterManager(), statementId)

Review Comment:
   Here the statementId is the Operation handle identifier not KyuubiBatchSession handle identifier.
   
   I think that it is better to use KyuubiBatchSession handle identifier, so that customers can also check batch job application by batch id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org