You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/08 11:53:06 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #10381:
[FLINK-14513][hive] Implement listPartitionsByFilter to HiveCatalog
KurtYoung commented on a change in pull request #10381: [FLINK-14513][hive] Implement listPartitionsByFilter to HiveCatalog
URL: https://github.com/apache/flink/pull/10381#discussion_r355180574
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceTest.java
##########
@@ -199,6 +204,47 @@ public void testPartitionPrunning() throws Exception {
assertArrayEquals(new String[]{"2014,3,0", "2014,4,0"}, rowStrings);
}
+ @Test
+ public void testPartitionFilter() throws Exception {
Review comment:
Could you also test the reading behavior in this case? By adding some data to the table and verify the results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services