You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/28 03:37:34 UTC

[GitHub] [airflow] randr97 commented on a change in pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook

randr97 commented on a change in pull request #8429:
URL: https://github.com/apache/airflow/pull/8429#discussion_r416302309



##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -66,7 +75,7 @@ def get_conn(self, headers=None):
             if conn.port:
                 self.base_url = self.base_url + ":" + str(conn.port)
             if conn.login:
-                session.auth = (conn.login, conn.password)
+                session.auth = self.auth_type(conn.login, conn.password)

Review comment:
       @mik-laj the reason why I have given a default value is cus of backward compatibility.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org