You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/10/20 11:13:55 UTC
[GitHub] [dubbo] EarthChen opened a new issue, #10776: [Triple] Optimized wrapper mode performance
EarthChen opened a new issue, #10776:
URL: https://github.com/apache/dubbo/issues/10776
# Background
The current triple protocol only supports pb serialization temporarily, it is recommended to use idl to generate stub.
However, there are still many users (especially java) users who are not used to using idl to generate stubs, so the triple protocol serializes the user objects into bytes in order to be compatible with the user habits of dubbo2, and then uses pb for packaging. Although this solution is feasible, serialization twice will lead to poor performance。
## Describe the proposal
In order to solve the above problems, we first have to make the triple protocol not strongly bound to pb.
We can use the content-type transfer serialization type to support different serialization protocols.
> But it should be noted that compatibility with the existing wrapper mode is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] neighbor-uncleWang commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
neighbor-uncleWang commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1299815554
> @neighbor-uncleWang没有你找到的方式，可以给我发个联系邮件，一起在群里商量
好的，我的邮箱：1103450854@qq.com；我的钉钉号：aem-r6yu62kos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] neighbor-uncleWang commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
neighbor-uncleWang commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1298296549
@EarthChen 大佬，我理解了一下，现在就是要将Triple和protobuf解耦，让triple 支持更多的序列化方式；序列化定义是通过content-type传递进来的，是不是意味着用户可以指定序列化协议；这这两天看一下代码，改动似乎不小；如果要支持其他序列化协议，我们优先支持哪几种呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] neighbor-uncleWang commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
neighbor-uncleWang commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1291439453
> > I am very interested in this question, can you give it to me?
>
> Fine go ahead
大佬，你好，我目前是第一次做找个，对triple 还不是很熟悉，目前项目里面有测试用例可以走这个流程吗？我需要一个用例熟悉流程；；如果没有测试用例，可否告知一个入口，让我减少熟悉项目的时间；感激不尽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] neighbor-uncleWang commented on issue #10776: [Triple] Optimized wrapper mode performance
Posted by GitBox <gi...@apache.org>.
neighbor-uncleWang commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1289097531
I am very interested in this question, can you give it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1298484988
> @EarthChen 大佬，我理解了一下，现在就是要将Triple和protobuf解耦，让triple 支持更多的序列化方式；序列化定义是通过content-type传递进来的，是不是意味着用户可以指定序列化协议；这这两天看一下代码，改动似乎不小；如果要支持其他序列化协议，我们优先支持哪几种呢？
不用特殊去支持哪几种，我们直接用 dubbo 的序列化的 spi 就可以的，改动应该还可控 可以客户端和服务端分开实现，优先实现服务端
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
guohao commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1330008026
Seems this issue is depending on https://github.com/apache/dubbo/issues/11047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1298490779
@neighbor-uncleWang 没有找到你的联系方式，可以给我发个邮件 ，一起在群里探讨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #10776: [Triple] Optimize wrapper mode performance
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1291495445
> > > I am very interested in this question, can you give it to me?
> >
> >
> > Fine go ahead
>
> 大佬，你好，我目前是第一次做找个，对triple 还不是很熟悉，目前项目里面有测试用例可以走这个流程吗？我需要一个用例熟悉流程；；如果没有测试用例，可否告知一个入口，让我减少熟悉项目的时间；感激不尽
可以到 dubbo-sample中查看用例 https://github.com/apache/dubbo-samples/blob/master/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/BaseTriPojoClientTest.java
dubbo 项目中的入口可以从`org.apache.dubbo.rpc.protocol.tri.TripleInvoker` 入手
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #10776: [Triple] Optimized wrapper mode performance
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #10776:
URL: https://github.com/apache/dubbo/issues/10776#issuecomment-1289939854
> I am very interested in this question, can you give it to me?
Fine go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org