You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by yeongeon <gi...@git.apache.org> on 2015/07/29 11:51:16 UTC
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
GitHub user yeongeon opened a pull request:
https://github.com/apache/tajo/pull/664
TAJO-1711: Add basic monitoring page
Add basic monitoring page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yeongeon/tajo TAJO-1711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #664
----
commit ef038f6f167b5d7acadae856c80eb99efdf3ccbd
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-24T09:32:04Z
#TAJO-1711 Add basic monitoring page
commit e55d0b0de61319dbe978c076519844b72f25b048
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-27T10:18:29Z
Merge branch 'master' of https://github.com/apache/tajo into TAJO-1711
# Conflicts:
# tajo-core/src/main/java/org/apache/tajo/util/metrics/TajoMetrics.java
# tajo-core/src/main/java/org/apache/tajo/webapp/servlet/MasterQueryExecutorServlet.java
commit 7b1d0cfb35e8d0e9dc76192a650932271df0c450
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-27T12:04:56Z
add license
commit 533a4a4f81ae7b19765e1626b8b6a5159d02fa4a
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-27T12:16:32Z
seperated tajo and monitoring.
commit fe5d3b5978eebb85670d1dcb67ca460f14d1d23c
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-28T01:24:28Z
merge with master
commit 04e28d4dc6573de455d146b73f38d5465234a179
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-28T23:06:47Z
add menu
fixed js
commit f9fd305f36e970f847391f99cc936b05ca3fadc4
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-29T09:29:59Z
add refresh.
save node at localstorage.
commit e7da481c387f6d08d38527891508b4191c222148
Author: yeongeon <ye...@gmail.com>
Date: 2015-07-29T09:39:36Z
changed servlet name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/664#discussion_r36607156
--- Diff: tajo-core/src/main/resources/webapps/admin/header.jsp ---
@@ -26,6 +26,7 @@
<li><a class='top_menu_item' href='query.jsp'>Query</a></li>
<li><a class='top_menu_item' href='catalogview.jsp'>Catalog</a></li>
<li><a class='top_menu_item' href='query_executor.jsp'>Execute Query</a></li>
+ <li><a class='top_menu_item' href='monitoring.jsp'>Basic Monitoring</a></li>
--- End diff --
Simply ```Monitoring``` looks more appropriate because we don't provide any complex or advanced monitoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/664#issuecomment-129337925
@jinossy We don't need to add d3 license to LICENSE file if it is under ASF 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/664#issuecomment-126549643
@hyunsik
nv.d3.js license seems to apache 2.0. Should we add d3 license to LICENSE file ?
https://github.com/novus/nvd3/blob/master/LICENSE.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/664#issuecomment-129343778
For clear, it would be better if you add this license (https://github.com/novus/nvd3/blob/master/LICENSE.md) into LICENSE file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1711: Add basic monitoring page
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/664#issuecomment-131549608
Hi @yeongeon,
This work looks great to me. But, it includes per-node monitoring feature. But, it is not fit in Tajo web page because Tajo basically aims at a number of nodes.
If you want to put a single page monitoring to Tajo, it would be great if the page is a summary page to give an overview of cluster, query, and scheduling information.
So, this work needs more work to remove worker parts and add some more information for an overview of them. For this, it would be great if you continue this work in a separate branch because 0.11.0 release is approaching.
I'll look forward to your comments. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---