You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 12:02:23 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10441: Fix docs build uploading artifacts

mik-laj commented on a change in pull request #10441:
URL: https://github.com/apache/airflow/pull/10441#discussion_r475549647



##########
File path: scripts/in_container/run_docs_build.sh
##########
@@ -28,7 +28,7 @@ sudo rm -rf "${AIRFLOW_SOURCES}/docs/_api/*"
 
 sudo -E "${AIRFLOW_SOURCES}/docs/build_docs.py" "${@}"
 
-if [[ ${GITHUB_ACTIONS} == "true" && -d "${AIRFLOW_SOURCES}/docs/_build/html" ]]; then
+if [[ ${GITHUB_ACTIONS:="false"} == "true" && -d "${AIRFLOW_SOURCES}/docs/_build/html" ]]; then
     rm -rf "/files/documentation"
     cp -r "${AIRFLOW_SOURCES}/docs/_build/html" "/files/documentation"

Review comment:
       Should we move instead of copy? This is a lot of files and may take a moment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org