You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/22 09:26:35 UTC

[GitHub] [activemq-artemis] franz1981 commented on pull request #3223: ARTEMIS-2849 Eliminate zeroing of buffers while writing the ASYNCIO journal

franz1981 commented on pull request #3223:
URL: https://github.com/apache/activemq-artemis/pull/3223#issuecomment-662347163


   @clebertsuconic The fix seems to work fine, but I'm not very proud of the solution: if we want to write 128 bytes and the block size is 4096, `bufferControl` allocates (or can reuse) a 4096 sized ByteBuffer without zeroing it (that's nice), but the journal record still need to zero `4096 - 128` bytes to save having garbage data on the journal. If we write enough data this optimization can save lot of zeroing but cannot eliminate it.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org