You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:31:26 UTC
[GitHub] [arrow] pitrou opened a new pull request, #13025: MINOR: [C++] Fix building Flight tests
pitrou opened a new pull request, #13025:
URL: https://github.com/apache/arrow/pull/13025
Follow up to ARROW-16387, which enabled `-Wshorten-64-to-32` with CLang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112325954
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112292699
Note this may be too large for a minor PR, so happy to open a JIRA if preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112287697
cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112287607
Actually, CHECKIN is enabled on CI, but the clang version there is perhaps less picky. Also Flight SQL is disabled on some of the builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112367029
Revision: 5aa039743a2401dcc07a7103ed58cb51e454a3a0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1987](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1987)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1987-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1987-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #13025: MINOR: [C++] Fix building Flight tests
URL: https://github.com/apache/arrow/pull/13025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1112281709
I'm surprised this wasn't caught by CI, perhaps CHECKIN isn't enabled there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13025: MINOR: [C++] Fix building Flight tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13025:
URL: https://github.com/apache/arrow/pull/13025#issuecomment-1117551375
Benchmark runs are scheduled for baseline = 9d6739e6c58f5d95da242190cd38935ad8f0cb1d and contender = 306d0b4144527fb988da3b64ec74b53536d974f0. 306d0b4144527fb988da3b64ec74b53536d974f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b49e5123eb0349898190f60a9b89a68a...f4dcf212420b4167881b07a96566a4f1/)
[Finished :arrow_down:0.19% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6e06609d1eb4bc68ffa3cc9df2f8e75...4c352cb597d841cbbce3cde7a1787dc9/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/89f3086fc4e4482b9b5dc26a62ac09c6...ef1426a8dc6449aeae59c4388c321c12/)
[Finished :arrow_down:0.16% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a0f78c9cb36c4dd48c7d6c66bf0f42a2...1498a7d482d94f3690b129f26d88f02f/)
Buildkite builds:
[Finished] [`306d0b41` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/663)
[Finished] [`306d0b41` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/661)
[Finished] [`306d0b41` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/650)
[Finished] [`306d0b41` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/666)
[Finished] [`9d6739e6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/662)
[Finished] [`9d6739e6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/660)
[Finished] [`9d6739e6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/649)
[Finished] [`9d6739e6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/665)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org