You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2024/01/12 10:51:16 UTC
[PR] [refactor](insert) remove unused insert code in FE [doris]
morningman opened a new pull request, #29924:
URL: https://github.com/apache/doris/pull/29924
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1890233543
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893141688
<details>
<summary>TPC-DS: <b>Total hot run time: 177823 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8a1817a09972774226c3028092202bb7bcbc538e, data reload: false
query1 938 327 326 326
query2 6737 1948 1830 1830
query3 6709 207 206 206
query4 37509 22236 22020 22020
query5 6942 549 597 549
query6 260 187 185 185
query7 4621 273 264 264
query8 236 200 197 197
query9 9259 2786 2690 2690
query10 572 244 237 237
query11 16256 15317 15239 15239
query12 130 70 71 70
query13 1690 398 384 384
query14 11320 7414 7334 7334
query15 217 193 184 184
query16 4623 258 250 250
query17 997 492 484 484
query18 1804 268 254 254
query19 186 153 150 150
query20 80 80 71 71
query21 190 140 118 118
query22 4992 4589 4713 4589
query23 31699 31032 31040 31032
query24 6899 2830 2817 2817
query25 414 327 333 327
query26 728 148 154 148
query27 2273 274 277 274
query28 3852 1860 1836 1836
query29 995 697 681 681
query30 203 137 139 137
query31 942 748 768 748
query32 69 59 61 59
query33 434 234 237 234
query34 820 443 463 443
query35 897 799 753 753
query36 1389 1222 1252 1222
query37 102 64 68 64
query38 3368 3285 3258 3258
query39 1318 1266 1281 1266
query40 213 99 95 95
query41 39 36 36 36
query42 99 94 97 94
query43 539 534 504 504
query44 1023 689 705 689
query45 200 192 179 179
query46 1046 642 648 642
query47 1630 1604 1608 1604
query48 401 323 334 323
query49 617 307 318 307
query50 711 307 308 307
query51 5356 5134 5193 5134
query52 101 95 98 95
query53 359 289 287 287
query54 744 452 462 452
query55 97 93 89 89
query56 212 192 197 192
query57 1046 953 929 929
query58 201 193 183 183
query59 3088 2820 2799 2799
query60 238 243 207 207
query61 84 88 85 85
query62 482 410 415 410
query63 305 278 289 278
query64 2629 1719 1690 1690
query65 3397 3297 3267 3267
query66 1039 335 322 322
query67 15546 14807 15217 14807
query68 11520 505 527 505
query69 632 333 338 333
query70 1646 1507 1585 1507
query71 522 239 247 239
query72 5164 2838 2842 2838
query73 2119 312 319 312
query74 8070 6463 6517 6463
query75 5005 2307 2328 2307
query76 6118 951 1012 951
query77 705 297 282 282
query78 9449 8791 8512 8512
query79 1013 498 504 498
query80 581 358 337 337
query81 483 200 201 200
query82 204 89 90 89
query83 139 117 118 117
query84 278 72 71 71
query85 1056 336 323 323
query86 381 355 424 355
query87 3555 3422 3369 3369
query88 3048 2152 2155 2152
query89 464 385 379 379
query90 2271 200 195 195
query91 156 120 123 120
query92 62 54 51 51
query93 1588 409 422 409
query94 1472 180 183 180
query95 524 462 476 462
query96 629 301 306 301
query97 4292 4124 4160 4124
query98 206 195 180 180
query99 1022 726 736 726
Total cold run time: 288486 ms
Total hot run time: 177823 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893148866
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 8a1817a09972774226c3028092202bb7bcbc538e with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.9 seconds inserted 10000000 Rows, about 671K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1889231163
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29924:
URL: https://github.com/apache/doris/pull/29924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893131422
<details>
<summary>TPC-H: <b>Total hot run time: 39143 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8a1817a09972774226c3028092202bb7bcbc538e, data reload: false
------ Round 1 ----------------------------------
q1 18023 6210 5590 5590
q2 2051 142 135 135
q3 10853 1104 1098 1098
q4 10488 798 801 798
q5 7842 3192 3165 3165
q6 206 121 122 121
q7 905 510 487 487
q8 9250 1943 1996 1943
q9 7267 6401 6398 6398
q10 8208 3045 3071 3045
q11 417 213 206 206
q12 357 194 193 193
q13 18117 3443 3351 3351
q14 252 221 222 221
q15 557 510 506 506
q16 432 398 375 375
q17 945 529 496 496
q18 7524 6975 6806 6806
q19 1604 1355 1297 1297
q20 586 296 273 273
q21 2886 2338 2457 2338
q22 376 301 309 301
Total cold run time: 109146 ms
Total hot run time: 39143 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5862 5573 5615 5573
q2 345 229 224 224
q3 3283 3061 3120 3061
q4 2180 2188 2041 2041
q5 6068 5954 5938 5938
q6 201 126 120 120
q7 2430 1998 1953 1953
q8 3591 3718 3704 3704
q9 9610 27370 9566 9566
q10 6471 3799 3859 3799
q11 679 461 453 453
q12 1229 646 658 646
q13 17089 3269 3262 3262
q14 354 247 260 247
q15 573 508 512 508
q16 528 486 474 474
q17 8959 2036 1840 1840
q18 9258 9715 12465 9715
q19 13323 1633 1631 1631
q20 3814 1926 1934 1926
q21 14274 6200 5576 5576
q22 840 580 599 580
Total cold run time: 110961 ms
Total hot run time: 62837 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893104106
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1888883555
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893753088
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1889403872
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1893146327
<details>
<summary>ClickBench: <b>Total hot run time: 30.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a1817a09972774226c3028092202bb7bcbc538e, data reload: false
query1 0.06 0.05 0.05
query2 0.07 0.02 0.02
query3 0.25 0.12 0.11
query4 1.78 0.12 0.12
query5 0.53 0.53 0.53
query6 1.37 0.62 0.64
query7 0.01 0.01 0.02
query8 0.03 0.02 0.02
query9 0.55 0.49 0.50
query10 0.57 0.56 0.55
query11 0.12 0.09 0.09
query12 0.11 0.09 0.09
query13 0.61 0.60 0.60
query14 0.77 0.76 0.79
query15 0.80 0.77 0.77
query16 0.37 0.38 0.36
query17 1.01 1.00 1.04
query18 0.23 0.27 0.24
query19 1.86 1.80 1.79
query20 0.01 0.01 0.01
query21 15.41 0.60 0.58
query22 2.63 2.37 1.99
query23 17.58 0.90 0.75
query24 2.67 0.74 1.43
query25 0.42 0.38 0.17
query26 0.47 0.14 0.13
query27 0.06 0.05 0.04
query28 11.60 0.80 0.78
query29 12.55 3.22 3.26
query30 0.59 0.48 0.50
query31 2.78 0.35 0.34
query32 3.39 0.49 0.49
query33 3.21 3.24 3.19
query34 15.82 4.23 4.22
query35 4.27 4.29 4.19
query36 1.12 1.08 1.08
query37 0.07 0.05 0.05
query38 0.03 0.02 0.02
query39 0.02 0.01 0.01
query40 0.16 0.13 0.12
query41 0.07 0.02 0.01
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 106.08 s
Total hot run time: 30.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](insert) remove unused insert code in FE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29924:
URL: https://github.com/apache/doris/pull/29924#issuecomment-1889231069
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org