You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/02/21 02:39:40 UTC
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Hello Michael Ho, Alex Rodoni, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12546
to review the following change.
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Reviewed-on: http://gerrit.cloudera.org:8080/10751
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12546/1
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/224/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 02:39:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/224/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 02:44:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Reviewed-on: http://gerrit.cloudera.org:8080/10751
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12546
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/225/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 02:41:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 05:52:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/225/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 02:44:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 2:
The --trusted_subnets flag is defined in be/src/kudu/rpc/server_negotiation.cc introduced by https://gerrit.cloudera.org/c/10757/
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 03:00:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12546 )
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
Patch Set 3:
Thank you, Tim!
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 06:08:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Alex Rodoni, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12546
to look at the new patch set (#2).
Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
......................................................................
IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed
Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Reviewed-on: http://gerrit.cloudera.org:8080/10751
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_known_issues.xml
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12546/2
--
To view, visit http://gerrit.cloudera.org:8080/12546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9db28d42fccd9711635c6aee66f2aafc758d58d0
Gerrit-Change-Number: 12546
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>