You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/29 09:37:22 UTC
[GitHub] [spark] Yikun opened a new pull request #36001: [SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos
Yikun opened a new pull request #36001:
URL: https://github.com/apache/spark/pull/36001
### What changes were proposed in this pull request?
Add note for specific scheduler configuration and fix typos
### Why are the changes needed?
We address some comments on https://github.com/apache/spark/pull/35955
### Does this PR introduce _any_ user-facing change?
No, doc only
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #36001: [SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #36001:
URL: https://github.com/apache/spark/pull/36001#discussion_r840605973
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1717,14 +1717,14 @@ spec:
Spark allows users to specify a custom Kubernetes schedulers.
-1. Specify scheduler name.
+1. Specify a scheduler name.
- Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ Users can specify custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
Review comment:
"a" was correct here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #36001: [SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #36001:
URL: https://github.com/apache/spark/pull/36001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #36001: [SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #36001:
URL: https://github.com/apache/spark/pull/36001#issuecomment-1086487620
@srowen Thanks for review, I'm not a native speaker, lack the mastery of words. I'm so sorry about back and forth due to tiny typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36001: [SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #36001:
URL: https://github.com/apache/spark/pull/36001#issuecomment-1086674529
Merged to master (conflicted with 3.3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org