You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/16 17:39:18 UTC
[GitHub] [skywalking-kong] dmsolr opened a new pull request #2: setup e2e test
dmsolr opened a new pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#issuecomment-821833872
@dmsolr Please fix tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r615407014
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
We haven't to. You could set the traffic back to another point of Kong/Nginx, as a cycle. Then you have a way to check.
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
We haven't to. You could set the traffic back to another URI of Kong/Nginx, as a cycle. Then you have a way to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] dmsolr commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r615404862
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
yeah. Currently, we don't have to trace the upstream. If so, we have to deploy another service as the upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r617168252
##########
File path: test/e2e/e2e-test/kong/docker/entrypoint.sh
##########
@@ -18,11 +18,11 @@
# export KONG_NGINX_HTTP_LUA_SHARED_DICT="tracing_buffer 128m"
-wget -P ~/ https://github.com/apache/skywalking-nginx-lua/archive/refs/heads/master.zip
+wget -P ~/ -O master.zip https://github.com/apache/skywalking-nginx-lua/archive/39686396ae23d7d341a8ff2212888f02d0b19f6d.zip
unzip -q ~/master.zip -d ~/
-cd ~/skywalking-nginx-lua-master
+cd ~/skywalking-nginx-lua-*
Review comment:
I think it doesn't use downloading the tar zip, https://github.com/apache/skywalking/blob/master/test/plugin/agent-test-tools/bin/fetch-code.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] dmsolr commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r615414937
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#issuecomment-821744327
With testing this repo, please remove the legacy codes in the https://github.com/apache/skywalking-nginx-lua repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r615404483
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
I think you should verify another segment referencing this exit span?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r616807393
##########
File path: test/e2e/e2e-test/kong/docker/entrypoint.sh
##########
@@ -0,0 +1,35 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# export KONG_NGINX_HTTP_LUA_SHARED_DICT="tracing_buffer 128m"
+
+wget -P ~/ https://github.com/apache/skywalking-nginx-lua/archive/refs/heads/master.zip
Review comment:
Please use commit id to clone codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng merged pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] dmsolr commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r615404862
##########
File path: test/e2e/e2e-test/kong/src/test/resources/expectedData.yaml
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+- serviceName: kong
+ segmentSize: eq 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: "/mock"
Review comment:
yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] dmsolr commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r617166000
##########
File path: test/e2e/e2e-test/kong/docker/entrypoint.sh
##########
@@ -18,11 +18,11 @@
# export KONG_NGINX_HTTP_LUA_SHARED_DICT="tracing_buffer 128m"
-wget -P ~/ https://github.com/apache/skywalking-nginx-lua/archive/refs/heads/master.zip
+wget -P ~/ -O master.zip https://github.com/apache/skywalking-nginx-lua/archive/39686396ae23d7d341a8ff2212888f02d0b19f6d.zip
unzip -q ~/master.zip -d ~/
-cd ~/skywalking-nginx-lua-master
+cd ~/skywalking-nginx-lua-*
Review comment:
Downloading resource codes are also very widely used in SkyWalking testing scenario.
Whether am I missing something that you are concern about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #2: setup e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-kong/pull/2#discussion_r617164032
##########
File path: test/e2e/e2e-test/kong/docker/entrypoint.sh
##########
@@ -18,11 +18,11 @@
# export KONG_NGINX_HTTP_LUA_SHARED_DICT="tracing_buffer 128m"
-wget -P ~/ https://github.com/apache/skywalking-nginx-lua/archive/refs/heads/master.zip
+wget -P ~/ -O master.zip https://github.com/apache/skywalking-nginx-lua/archive/39686396ae23d7d341a8ff2212888f02d0b19f6d.zip
unzip -q ~/master.zip -d ~/
-cd ~/skywalking-nginx-lua-master
+cd ~/skywalking-nginx-lua-*
Review comment:
I think it is better to use `git clone`? Such as
```
# make a new blank repository in the current directory
git init
# add a remote
git remote add origin url://to/source/repository
# fetch a commit (or branch or tag) of interest
# Note: the full history up to this commit will be retrieved unless
# you limit it with '--depth=...' or '--shallow-since=...'
git fetch origin <sha1-of-commit-of-interest>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org