You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/17 10:58:25 UTC

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #19287: ExpressionProjection add parameters field to support expression aggregation

strongduanmu commented on code in PR #19287:
URL: https://github.com/apache/shardingsphere/pull/19287#discussion_r922813821


##########
shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/impl/AggregationProjection.java:
##########
@@ -45,7 +43,8 @@ public class AggregationProjection implements Projection {
     
     private final String innerExpression;
     
-    private final String alias;

Review Comment:
   Why remove final modifier?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org