You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/27 21:13:56 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #5135: Core: Fix REST field name case strategy and ensure field name tests are for serialized versions

rdblue commented on code in PR #5135:
URL: https://github.com/apache/iceberg/pull/5135#discussion_r907802514


##########
core/src/test/java/org/apache/iceberg/rest/requests/TestUpdateNamespacePropertiesRequest.java:
##########
@@ -206,7 +206,7 @@ public void testBuilderDoesNotCreateInvalidObjects() {
 
   @Override
   public String[] allFieldsFromSpec() {
-    return new String[] { "updates", "removals" };
+    return new String[] { "removals", "updates" };

Review Comment:
   I think it would be best to revert this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org