You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/01/20 15:51:31 UTC
Review Request 42553: Add params to alert definitions during ambari
upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42553/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-14740
https://issues.apache.org/jira/browse/AMBARI-14740
Repository: ambari
Description
-------
We have many parameters for different alert dfeinitions. But these parameters will be available only when you are deploying new cluster. If you are upgrading to the last version of ambari, these params will be not available, because they were not added during ambari upgrade. We have no code in UpgradeCatalogs which should add all these params.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 82aa6ca
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/42553/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 42553: Add params to alert definitions during
ambari upgrade
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42553/#review115429
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 20, 2016, 4:51 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42553/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 4:51 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14740
> https://issues.apache.org/jira/browse/AMBARI-14740
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have many parameters for different alert dfeinitions. But these parameters will be available only when you are deploying new cluster. If you are upgrading to the last version of ambari, these params will be not available, because they were not added during ambari upgrade. We have no code in UpgradeCatalogs which should add all these params.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 82aa6ca
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42553/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>