You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "sgendre (via GitHub)" <gi...@apache.org> on 2026/09/25 13:22:07 UTC

[PR] core-spec: add QLIKSCRIPT to the Dialect enum [ossie]

sgendre opened a new pull request, #470:
URL: https://github.com/apache/ossie/pull/470

   Registers QLIKSCRIPT (Qlik Cloud's chart-expression function library, not SQL) as an additional Dialect value in ossie-schema.json, mirroring it in spec.yaml and the Python SDK's OssieDialect enum. Additive only, following the OSSIE_SQL_2026 precedent (#439/#440): no existing value renamed or removed.
   
   Unblocks TLV-2293's Qlik Cloud <-> Ossie semantic model converter (apache/data-product-spec), whose measure/dimension expressions[] dialect mapping ("qlik" -> QLIKSCRIPT) currently has no legal target value to emit.
   
   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   ## Summary
   
   <!-- Describe what this PR does and why. -->
   
   ## Related Issues
   
   <!-- Link any related GitHub issues: Closes #123, Fixes #456 -->
   
   ## Checklist
   
   ### Specification
   - [ ] Spec changes are included in `core-spec/` and follow the existing structure
   - [ ] Spec changes have been discussed on the mailing list or in a linked issue
   - [ ] Breaking changes to the spec are clearly called out in the summary
   
   ### Ontology
   - [ ] Ontology changes in `ontology/` are consistent with spec changes
   - [ ] New or modified terms are defined and documented
   
   ### Converters
   - [ ] Converter logic in `converters/` is updated to reflect spec or ontology changes
   - [ ] New converters include tests under the converter's test directory
   
   ### Validation
   - [ ] Validation rules in `validation/` are updated if the spec changed
   - [ ] New validation cases are covered by tests
   
   ### Documentation
   - [ ] `docs/` is updated to reflect any user-facing changes
   - [ ] New features or behaviors are documented with examples where appropriate
   - [ ] `CONTRIBUTING.md` is updated if the contribution process changed
   
   ### Examples
   - [ ] `examples/` are added or updated for any new spec constructs or converter support
   
   ### Tests
   - [ ] All existing tests pass (`pytest` / CI green)
   - [ ] New functionality is covered by tests
   
   ### Compliance
   - [ ] ASF license headers are present on all new source files
   - [ ] No third-party dependencies are added without PMC/IPMC approval


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] core-spec: add QLIKSCRIPT to the Dialect enum [ossie]

Posted by "sgendre (via GitHub)" <gi...@apache.org>.
sgendre closed pull request #470: core-spec: add QLIKSCRIPT to the Dialect enum
URL: https://github.com/apache/ossie/pull/470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] core-spec: add QLIKSCRIPT to the Dialect enum [ossie]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #470:
URL: https://github.com/apache/ossie/pull/470#discussion_r4104935857


##########
core-spec/spec.yaml:
##########
@@ -42,6 +42,7 @@ dialects:
   - "THOUGHTSPOT"           # ThoughtSpot formula language (not SQL)
   - "DAX"                   # Data Analysis Expressions (Power BI / Analysis Services)
   - "OSSIE_SQL_2026"        # Ossie portable SQL expression language (see expression_language.md)
+  - "QLIKSCRIPT"            # Qlik Cloud chart-expression function library (not SQL)

Review Comment:
   This `dialects` block is generated by `scripts/generate-spec-types.py`, but that generator's description map has no `QLIKSCRIPT` entry. Consequently `generate-spec-types.py --check` reports `spec.yaml` out of sync, and `--apply` removes this inline comment. Add the description to the generator and regenerate so the checked-in generated file remains reproducible.
   
   This issue also appears on line 45 of the same file.



##########
core-spec/ossie-schema.json:
##########
@@ -37,7 +37,7 @@
   "$defs": {
     "Dialect": {
       "type": "string",
-      "enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "OSSIE_SQL_2026"],
+      "enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "OSSIE_SQL_2026", "QLIKSCRIPT"],

Review Comment:
   The human-readable Dialects table in `core-spec/spec.md:48-64` still ends at `OSSIE_SQL_2026`, so this new schema/SDK value is accepted but omitted from the core specification documentation. Add a `QLIKSCRIPT` row with the same description before merging to keep the documented enum complete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org