[jira] [Commented] (MATH-863) new Quaternion class added in complex package

["Gilles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MATH-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458256#comment-13458256 ] 

Gilles commented on MATH-863:
-----------------------------

Thanks for the proposed implementations.

No need to apologize... ;)

Concerning the Javadoc formatting (it's a hot topic at the moment, see MATH-852):
* Do not insert a ":" character between the parameter's name and description.
* It's no necessary to tag all methods with "@since 3.1" (since the entire class is new).

There are other little things... Some remarks that have been listed in MATH-815 might also apply here.

One important thing is to provide separate patches for independent issues:
# New methods for {{Precision}} class
# Quaternion implementation

If I read carefully, the "equalsWithRelativeTolerance" is used at only one place in "Quaternion", and at that place, I think that the existing "Precision.equals" method could be used instead.
Anyways, the proposal for the new methods should be discussed on the "dev" ML, and handled in a separate JIRA ticket.

About the "Quaternion" class, some points need clarification:
* "static" methods might have to be replaced by instance methods (as in class "Complex").
* "isEqualTo" should probably be replaced by the standard "equals" method.
* It might be better to avoid referring to "Vector3D" inside this class: Some methods are only syntactic sugar (grouping 3 scalars in 1 vector) or utilities probably best defined somewhere in the "geometry" package.

Could you please open a discussion on the "dev" ML?

                
> new Quaternion class added in complex package
> ---------------------------------------------
>
>                 Key: MATH-863
>                 URL: https://issues.apache.org/jira/browse/MATH-863
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.1
>            Reporter: Julien Anxionnat
>         Attachments: quaternion.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch provides a new class for the mathematical object "Quaternion" in the complex package.
> This quaternion is considered as a mathematical object (the Hamilton's hypercomplex number).
> Note that it's not a rotation quaternion which has to be a quaternion of norm one. Although this feature could be used for a getter in the Rotation class.
> This patch provides also some improvements in Precision class : a "double comparison epsilon" and a method to compute relative comparison.
> (Please, note that's it's my first contribution, and I apologize in advance for my mistakes…) 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira