You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Qingsheng Ren (Jira)" <ji...@apache.org> on 2022/07/11 01:59:00 UTC
[jira] [Commented] (FLINK-28454) Fix the wrong timestamp example of KafkaSource
[ https://issues.apache.org/jira/browse/FLINK-28454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564751#comment-17564751 ]
Qingsheng Ren commented on FLINK-28454:
---------------------------------------
Merged to master: ce56e01aeaa6ebd3b350fe089a952f238742823c
> Fix the wrong timestamp example of KafkaSource
> ----------------------------------------------
>
> Key: FLINK-28454
> URL: https://issues.apache.org/jira/browse/FLINK-28454
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka, Documentation
> Affects Versions: 1.13.6, 1.14.5, 1.15.1
> Reporter: fanrui
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0, 1.15.2
>
> Attachments: image-2022-07-08-13-04-59-993.png, image-2022-07-08-13-42-49-902.png, image-2022-07-08-13-43-14-278.png, image-2022-07-08-13-46-05-540.png
>
>
> [https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/connectors/datastream/kafka/]
>
> The timestamp unit of startingOffset is second in kafkaSource doc, but it should be milliseconds. It will mislead flink users.
>
> !image-2022-07-08-13-04-59-993.png!
>
>
> It should be milliseconds, because the timestamp is used in OffsetSpec.fromTimestamp() , and the comment is : *@param timestamp in milliseconds*
>
> By the way, the timestamp is milliseconds in old source doc. link: [https://nightlies.apache.org/flink/flink-docs-release-1.13/docs/connectors/datastream/kafka/#kafka-consumers-start-position-configuration]
>
> !image-2022-07-08-13-46-05-540.png!
>
> !image-2022-07-08-13-42-49-902.png|width=1103,height=970!
>
> !image-2022-07-08-13-43-14-278.png|width=697,height=692!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)