You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/03 00:18:17 UTC

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #212: [YUNIKORN-433] Extend configwatcher expiration

yangwwei commented on pull request #212:
URL: https://github.com/apache/incubator-yunikorn-core/pull/212#issuecomment-703010362


   hi @kingamarton 
   
   Overall it looks good.
   Looks like there is a minor lint issue, pls fix it.
   Could you pls try to add UT in `configwatcher_test.go`? We already have something like `TestConfigWatcherExpiration()`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org