You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2024/01/30 03:14:31 UTC
[PR] [SCB-2857]Fix endpoint metrics not properly destroy and throw exception [servicecomb-java-chassis]
liubao68 opened a new pull request, #4209:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4209
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2857]Fix endpoint metrics not properly destroy and throw exception [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4209:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SCB-2857]Fix endpoint metrics not properly destroy and throw exception [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4209:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4209#issuecomment-1916013124
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `8 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`64742d0`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/64742d0926b2e646d760dbf5e27deaf9640bc713?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.73% compared to head [(`d2b2329`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.65%.
> :exclamation: Current head d2b2329 differs from pull request most recent head 1f0840c. Consider uploading reports for the commit 1f0840c to get more accurate results
| [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rics/core/meter/vertx/HttpClientEndpointMeter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci92ZXJ0eC9IdHRwQ2xpZW50RW5kcG9pbnRNZXRlci5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metrics/core/meter/vertx/ServerEndpointMeter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci92ZXJ0eC9TZXJ2ZXJFbmRwb2ludE1ldGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4209 +/- ##
============================================
- Coverage 44.73% 44.65% -0.09%
+ Complexity 5439 5431 -8
============================================
Files 1385 1385
Lines 34381 34387 +6
Branches 3326 3326
============================================
- Hits 15381 15356 -25
- Misses 17755 17789 +34
+ Partials 1245 1242 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org