You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/15 07:06:48 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6948: Fix issue 6945

wu-sheng commented on a change in pull request #6948:
URL: https://github.com/apache/skywalking/pull/6948#discussion_r632907736



##########
File path: CHANGES.md
##########
@@ -41,6 +41,7 @@ Release Notes.
 * Fix: Envoy error logs are not persisted when no metrics are generated
 * Fix: Memory leakage of low version etcd client. [fix-issue](https://github.com/jurmous/etcd4j/pull/185)
 * Allow multiple definitions as fallback in metadata-service-mapping.yaml file.
+* Fix: NPE when configmap has no data. [fix-issue](https://github.com/apache/skywalking/pull/6948)

Review comment:
       ```suggestion
   * Fix: NPE when configmap has no data. 
   ```
   
   SkyWalking native issue should not be linked in the changelog. Our git commit log already provides this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org