You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by xi...@apache.org on 2017/06/09 05:38:55 UTC

hadoop git commit: HADOOP-13854. KMS should log error details in KMSExceptionsProvider.

Repository: hadoop
Updated Branches:
  refs/heads/trunk 020248074 -> c4b5c3266


HADOOP-13854. KMS should log error details in KMSExceptionsProvider.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/c4b5c326
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/c4b5c326
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/c4b5c326

Branch: refs/heads/trunk
Commit: c4b5c32669423b9a792f33f9f8333d95528f2515
Parents: 0202480
Author: Xiao Chen <xi...@apache.org>
Authored: Thu Jun 8 22:35:31 2017 -0700
Committer: Xiao Chen <xi...@apache.org>
Committed: Thu Jun 8 22:35:31 2017 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java   | 2 +-
 .../hadoop/crypto/key/kms/server/KMSExceptionsProvider.java      | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4b5c326/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java b/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
index 5873c7a..27cc05d 100644
--- a/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
+++ b/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
@@ -70,7 +70,7 @@ public class KMS {
   private KeyProviderCryptoExtension provider;
   private KMSAudit kmsAudit;
 
-  private static final Logger LOG = LoggerFactory.getLogger(KMS.class);
+  static final Logger LOG = LoggerFactory.getLogger(KMS.class);
 
   public KMS() throws Exception {
     provider = KMSWebApp.getKeyProvider();

http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4b5c326/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java
index aa9d299..3d97753 100644
--- a/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java
+++ b/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java
@@ -43,6 +43,7 @@ import java.io.IOException;
 public class KMSExceptionsProvider implements ExceptionMapper<Exception> {
   private static Logger LOG =
       LoggerFactory.getLogger(KMSExceptionsProvider.class);
+  private final static Logger EXCEPTION_LOG = KMS.LOG;
 
   private static final String ENTER = System.getProperty("line.separator");
 
@@ -100,6 +101,9 @@ public class KMSExceptionsProvider implements ExceptionMapper<Exception> {
           KMSMDCFilter.getMethod(),
           KMSMDCFilter.getURL(), getOneLineMessage(exception));
     }
+    EXCEPTION_LOG.warn("User {} request {} {} caused exception.",
+        KMSMDCFilter.getUgi(), KMSMDCFilter.getMethod(),
+        KMSMDCFilter.getURL(), exception);
     return createResponse(status, throwable);
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org