[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #128: HDDS-2415. Completely disable tracer if hdds.tracing.enabled=false

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #128: HDDS-2415. Completely disable tracer if hdds.tracing.enabled=false
URL: https://github.com/apache/hadoop-ozone/pull/128
 
 
   ## What changes were proposed in this pull request?
   
   Skip registering a real tracer with `GlobalTracer` if `hdds.tracing.enabled` is set to `false`.  This lets us avoid tracer-related busywork.
   
   https://issues.apache.org/jira/browse/HDDS-2415
   
   ## How was this patch tested?
   
   1. Checked Jaeger in `ozoneperf` cluster with default config, verified that it shows traces (OM, SCM, DN, Freon, S3 shell, Ozone shell)
   2. With `OZONE-SITE.XML_hdds.tracing.enabled=false` added to `docker-config`, verified that Jaeger shows no traces
   3. Also with tracing disabled in `ozone` cluster, verified that `GlobalTracer` no longer shows up in breakdown of allocations from `HddsDispatcher.dispatch` in the profiler

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org