You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2019/07/30 19:49:52 UTC

svn commit: r1864025 - in /subversion/trunk/subversion: libsvn_fs_fs/low_level.c libsvn_fs_x/low_level.c

Author: danielsh
Date: Tue Jul 30 19:49:52 2019
New Revision: 1864025

URL: http://svn.apache.org/viewvc?rev=1864025&view=rev
Log:
fsfs, fsx: Make an error message clearer to developers.

* subversion/libsvn_fs_fs/low_level.c
  (svn_fs_fs__parse_footer),
* subversion/libsvn_fs_x/low_level.c
  (svn_fs_x__parse_footer):
    Make the output radix explicit, so the values aren't mistaken for decimal.
    (Actually, I wonder why the values aren't printed in decimal to begin with.)

Modified:
    subversion/trunk/subversion/libsvn_fs_fs/low_level.c
    subversion/trunk/subversion/libsvn_fs_x/low_level.c

Modified: subversion/trunk/subversion/libsvn_fs_fs/low_level.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/low_level.c?rev=1864025&r1=1864024&r2=1864025&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/low_level.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/low_level.c Tue Jul 30 19:49:52 2019
@@ -254,10 +254,10 @@ svn_fs_fs__parse_footer(apr_off_t *l2p_o
                              "P2L offset %s must be larger than L2P offset %s"
                              " in r%ld footer",
                              apr_psprintf(result_pool,
-                                          "%" APR_UINT64_T_HEX_FMT,
+                                          "0x%" APR_UINT64_T_HEX_FMT,
                                           (apr_uint64_t)*p2l_offset),
                              apr_psprintf(result_pool,
-                                          "%" APR_UINT64_T_HEX_FMT,
+                                          "0x%" APR_UINT64_T_HEX_FMT,
                                           (apr_uint64_t)*l2p_offset),
                              rev);
 

Modified: subversion/trunk/subversion/libsvn_fs_x/low_level.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/low_level.c?rev=1864025&r1=1864024&r2=1864025&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/low_level.c (original)
+++ subversion/trunk/subversion/libsvn_fs_x/low_level.c Tue Jul 30 19:49:52 2019
@@ -167,10 +167,10 @@ svn_fs_x__parse_footer(apr_off_t *l2p_of
                              "P2L offset %s must be larger than L2P offset %s"
                              " in r%ld footer",
                              apr_psprintf(result_pool,
-                                          "%" APR_UINT64_T_HEX_FMT,
+                                          "0x%" APR_UINT64_T_HEX_FMT,
                                           (apr_uint64_t)*p2l_offset),
                              apr_psprintf(result_pool,
-                                          "%" APR_UINT64_T_HEX_FMT,
+                                          "0x%" APR_UINT64_T_HEX_FMT,
                                           (apr_uint64_t)*l2p_offset),
                              rev);