You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/06/25 23:40:55 UTC
[GitHub] [samza] lakshmi-manasa-g opened a new pull request #1507: SAMZA-2660: Add authentication via TokenCredential for AzureBlobSystemProducer
lakshmi-manasa-g opened a new pull request #1507:
URL: https://github.com/apache/samza/pull/1507
TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu merged pull request #1507: SAMZA-2660: Add authentication via TokenCredential for AzureBlobSystemProducer
Posted by GitBox <gi...@apache.org>.
rmatharu merged pull request #1507:
URL: https://github.com/apache/samza/pull/1507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on a change in pull request #1507: SAMZA-2660: Add authentication via TokenCredential for AzureBlobSystemProducer
Posted by GitBox <gi...@apache.org>.
rmatharu commented on a change in pull request #1507:
URL: https://github.com/apache/samza/pull/1507#discussion_r660221140
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/AzureBlobClientBuilder.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.samza.system.azureblob;
+
+import com.azure.core.credential.TokenCredential;
+import com.azure.core.http.ProxyOptions;
+import com.azure.core.http.netty.NettyAsyncHttpClientBuilder;
+import com.azure.core.http.policy.HttpLogDetailLevel;
+import com.azure.core.http.policy.HttpLogOptions;
+import com.azure.identity.ClientSecretCredentialBuilder;
+import com.azure.storage.blob.BlobServiceAsyncClient;
+import com.azure.storage.blob.BlobServiceClientBuilder;
+import com.azure.storage.common.StorageSharedKeyCredential;
+import java.net.InetSocketAddress;
+import com.azure.core.http.HttpClient;
+import java.util.Locale;
+
+
+public final class AzureBlobClientBuilder {
+ private final String systemName;
+ private final String azureUrlFormat;
+ private final AzureBlobConfig azureBlobConfig;
+ public AzureBlobClientBuilder(String systemName, String azureUrlFormat, AzureBlobConfig azureBlobConfig) {
+ this.systemName = systemName;
+ this.azureUrlFormat = azureUrlFormat;
+ this.azureBlobConfig = azureBlobConfig;
+ }
+ public BlobServiceAsyncClient getBlobServiceAsyncClient() {
Review comment:
Method seems to have a hierarchy on the credentials it uses to create client, need to add in the javadoc for the method.
Same for all methods below, need to add documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on a change in pull request #1507: SAMZA-2660: Add authentication via TokenCredential for AzureBlobSystemProducer
Posted by GitBox <gi...@apache.org>.
rmatharu commented on a change in pull request #1507:
URL: https://github.com/apache/samza/pull/1507#discussion_r660221140
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/AzureBlobClientBuilder.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.samza.system.azureblob;
+
+import com.azure.core.credential.TokenCredential;
+import com.azure.core.http.ProxyOptions;
+import com.azure.core.http.netty.NettyAsyncHttpClientBuilder;
+import com.azure.core.http.policy.HttpLogDetailLevel;
+import com.azure.core.http.policy.HttpLogOptions;
+import com.azure.identity.ClientSecretCredentialBuilder;
+import com.azure.storage.blob.BlobServiceAsyncClient;
+import com.azure.storage.blob.BlobServiceClientBuilder;
+import com.azure.storage.common.StorageSharedKeyCredential;
+import java.net.InetSocketAddress;
+import com.azure.core.http.HttpClient;
+import java.util.Locale;
+
+
+public final class AzureBlobClientBuilder {
+ private final String systemName;
+ private final String azureUrlFormat;
+ private final AzureBlobConfig azureBlobConfig;
+ public AzureBlobClientBuilder(String systemName, String azureUrlFormat, AzureBlobConfig azureBlobConfig) {
+ this.systemName = systemName;
+ this.azureUrlFormat = azureUrlFormat;
+ this.azureBlobConfig = azureBlobConfig;
+ }
+ public BlobServiceAsyncClient getBlobServiceAsyncClient() {
Review comment:
Method seems to have a hierarchy on the credentials it uses to create client, need to add in the javadoc for the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on a change in pull request #1507: SAMZA-2660: Add authentication via TokenCredential for AzureBlobSystemProducer
Posted by GitBox <gi...@apache.org>.
rmatharu commented on a change in pull request #1507:
URL: https://github.com/apache/samza/pull/1507#discussion_r660221140
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/AzureBlobClientBuilder.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.samza.system.azureblob;
+
+import com.azure.core.credential.TokenCredential;
+import com.azure.core.http.ProxyOptions;
+import com.azure.core.http.netty.NettyAsyncHttpClientBuilder;
+import com.azure.core.http.policy.HttpLogDetailLevel;
+import com.azure.core.http.policy.HttpLogOptions;
+import com.azure.identity.ClientSecretCredentialBuilder;
+import com.azure.storage.blob.BlobServiceAsyncClient;
+import com.azure.storage.blob.BlobServiceClientBuilder;
+import com.azure.storage.common.StorageSharedKeyCredential;
+import java.net.InetSocketAddress;
+import com.azure.core.http.HttpClient;
+import java.util.Locale;
+
+
+public final class AzureBlobClientBuilder {
+ private final String systemName;
+ private final String azureUrlFormat;
+ private final AzureBlobConfig azureBlobConfig;
+ public AzureBlobClientBuilder(String systemName, String azureUrlFormat, AzureBlobConfig azureBlobConfig) {
+ this.systemName = systemName;
+ this.azureUrlFormat = azureUrlFormat;
+ this.azureBlobConfig = azureBlobConfig;
+ }
+ public BlobServiceAsyncClient getBlobServiceAsyncClient() {
Review comment:
Method seems to have a hierarchy on the credentials it uses to create client, need to add in the javadoc for the method.
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/AzureBlobClientBuilder.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.samza.system.azureblob;
+
+import com.azure.core.credential.TokenCredential;
+import com.azure.core.http.ProxyOptions;
+import com.azure.core.http.netty.NettyAsyncHttpClientBuilder;
+import com.azure.core.http.policy.HttpLogDetailLevel;
+import com.azure.core.http.policy.HttpLogOptions;
+import com.azure.identity.ClientSecretCredentialBuilder;
+import com.azure.storage.blob.BlobServiceAsyncClient;
+import com.azure.storage.blob.BlobServiceClientBuilder;
+import com.azure.storage.common.StorageSharedKeyCredential;
+import java.net.InetSocketAddress;
+import com.azure.core.http.HttpClient;
+import java.util.Locale;
+
+
+public final class AzureBlobClientBuilder {
+ private final String systemName;
+ private final String azureUrlFormat;
+ private final AzureBlobConfig azureBlobConfig;
+ public AzureBlobClientBuilder(String systemName, String azureUrlFormat, AzureBlobConfig azureBlobConfig) {
+ this.systemName = systemName;
+ this.azureUrlFormat = azureUrlFormat;
+ this.azureBlobConfig = azureBlobConfig;
+ }
+ public BlobServiceAsyncClient getBlobServiceAsyncClient() {
Review comment:
Method seems to have a hierarchy on the credentials it uses to create client, need to add in the javadoc for the method.
Same for all methods below, need to add documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org