You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/31 21:45:24 UTC

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation
URL: https://github.com/apache/helix/pull/367#discussion_r309445571
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
 ##########
 @@ -121,19 +125,24 @@ protected JsonNode getJsonObject(HttpResponse httpResponse) throws IOException {
   }
 
   @VisibleForTesting
-  protected HttpResponse post(String url, Map<String, String> payloads) throws IOException {
+  protected synchronized HttpResponse post(String url, Map<String, String> payloads) throws IOException {
 
 Review comment:
   Got it! I've changed the locking at `getParttionsStoppableCheck` method, can you take a look?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services