You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "daviddallakyan2005 (via GitHub)" <gi...@apache.org> on 2026/08/16 07:33:42 UTC
[PR] fix: stop calling deprecated PuffinFile.to_vector in Spark DV test [iceberg-python]
daviddallakyan2005 opened a new pull request, #3804:
URL: https://github.com/apache/iceberg-python/pull/3804
Closes #3803
# Rationale for this change
Follow-up to #3476. `test_read_spark_written_puffin_dv` still calls `PuffinFile.to_vector()`, which #3491 deprecated in 0.12.0. `filterwarnings = ["error"]` turns that into a hard CI failure, so `integration-test` is red on `main` and on unrelated PRs including #3801.
This test now uses `deletion_vectors_from_puffin_file(...)`, matching `pyiceberg/io/pyarrow.py`. Spark interop assertions are unchanged. Not part of #3801.
## Are these changes tested?
Yes. `make test-integration PYTEST_ARGS="-v -k test_read_spark_written_puffin_dv"` → 1 passed, 5517 deselected.
## Are there any user-facing changes?
No.
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: stop calling deprecated PuffinFile.to_vector in Spark DV test [iceberg-python]
Posted by "moomindani (via GitHub)" <gi...@apache.org>.
moomindani commented on PR #3804:
URL: https://github.com/apache/iceberg-python/pull/3804#issuecomment-5310405685
Thanks for catching and fixing this, @daviddallakyan2005, and sorry for the noise — the broken call came in with #3476.
For the record on the root cause: #3476's last commit was 2026-06-18, and #3491 deprecated `PuffinFile.to_vector()` on 2026-06-25. The test was green when it last ran and only went stale while the PR waited for a merge, which landed on 08-15 without a rebase — so CI never ran it against the current `main`.
The fix looks right to me. `DeletionVector.to_vector()` isn't deprecated, and the assertions are equivalent since the old loop never used the data file path key. I also checked that `test_deletes.py:1084` was the only remaining call site of the deprecated method on `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: stop calling deprecated PuffinFile.to_vector in Spark DV test [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #3804:
URL: https://github.com/apache/iceberg-python/pull/3804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: stop calling deprecated PuffinFile.to_vector in Spark DV test [iceberg-python]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on PR #3804:
URL: https://github.com/apache/iceberg-python/pull/3804#issuecomment-5310490114
This is simply a logical conflict. No need to apologize :)
We could consider enabling the merge queue so that we can re-run CI just before its merge. Here's a reference:
- https://github.com/apache/infrastructure-asfyaml/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: stop calling deprecated PuffinFile.to_vector in Spark DV test [iceberg-python]
Posted by "daviddallakyan2005 (via GitHub)" <gi...@apache.org>.
daviddallakyan2005 commented on PR #3804:
URL: https://github.com/apache/iceberg-python/pull/3804#issuecomment-5328302849
@ebyhr Could you merge this when you have a moment? `integration-test` uses `-x`, so the deprecated `PuffinFile.to_vector()` call in `test_read_spark_written_puffin_dv` is failing the job on `main` and on unrelated PRs. This PR is approved and CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org