You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/02 02:30:56 UTC
[GitHub] codecov-io edited a comment on issue #5186: Implement a React-based
table editor
codecov-io edited a comment on issue #5186: Implement a React-based table editor
URL: https://github.com/apache/incubator-superset/pull/5186#issuecomment-407238867
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=h1) Report
> Merging [#5186](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4bf69a7260f1d4c8fbfe9d9c0300cae39ca3bf81?src=pr&el=desc) will **increase** coverage by `0.22%`.
> The diff coverage is `76.32%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5186/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5186 +/- ##
==========================================
+ Coverage 63.29% 63.51% +0.22%
==========================================
Files 349 356 +7
Lines 22194 22677 +483
Branches 2467 2527 +60
==========================================
+ Hits 14047 14404 +357
- Misses 8133 8259 +126
Partials 14 14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `36.17% <0%> (ø)` | :arrow_up: |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0QXN5bmNDb250cm9sLmpzeA==) | `56% <0%> (-14%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.92% <100%> (+0.41%)` | :arrow_up: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVGV4dEFyZWFDb250cm9sLmpzeA==) | `97.29% <100%> (+0.07%)` | :arrow_up: |
| [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQ29udHJvbFBhbmVsc0NvbnRhaW5lci5qc3g=) | `88.15% <100%> (ø)` | :arrow_up: |
| [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/components/TableLoader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlTG9hZGVyLmpzeA==) | `48.57% <100%> (ø)` | |
| [...perset/assets/src/profile/components/Favorites.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9wcm9maWxlL2NvbXBvbmVudHMvRmF2b3JpdGVzLmpzeA==) | `100% <100%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.02% <100%> (-0.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/incubator-superset/pull/5186/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=footer). Last update [4bf69a7...adfbcca](https://codecov.io/gh/apache/incubator-superset/pull/5186?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org