You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2025/11/28 06:48:42 UTC
[PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
yihua opened a new pull request, #14381:
URL: https://github.com/apache/hudi/pull/14381
### Describe the issue this Pull Request addresses
Some Spark SQL tests are not executed in CI.
### Summary and Changelog
This PR enforces proper package structure for Spark SQL test classes under `org.apache.spark.sql.hudi` by:
- Adds `org.apache.spark.sql.hudi.catalog` to the allowed wildcard test suites in CI configuration
- Moves misplaced test classes from `org.apache.spark.sql.hudi` to `org.apache.spark.sql.hudi.common`
- Fixes package declarations and imports in affected test files
- Adds `TestSparkSqlHudiPackageStructure` which validates that Scala test classes under `org.apache.spark.sql.hudi` are only in allowed packages.
### Impact
Fixes test coverage and adds validation to guarantee test coverage in the future.
### Risk Level
none
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3591048598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3588248834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fecdd97c608e78cf174b1c81f19d1bb11c9369e3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #14381:
URL: https://github.com/apache/hudi/pull/14381#discussion_r2572845628
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestSparkSqlHudiPackageStructure.java:
##########
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * Validates that Scala test classes under org.apache.spark.sql.hudi are only in allowed packages.
+ * This ensures proper package structure for CI wildcard suite configurations.
+ * Only Scala test classes are checked; Java test classes are excluded.
+ */
+public class TestSparkSqlHudiPackageStructure {
+
+ private static final String BASE_PACKAGE = "org.apache.spark.sql.hudi";
+ private static final String PACKAGE_PATH = "org/apache/spark/sql/hudi";
+
+ /**
+ * Allowed sub-packages under org.apache.spark.sql.hudi for Scala test classes.
+ * These are referenced in azure-pipelines configuration for wildcard test suites.
Review Comment:
Nit: Add comment next to the `ALLOWED_PACKAGES` set to be explicit about the link. Something like:
```
NOTE: This list **MUST** be kept in sync with the 'packages' list in azure-pipelines-20230430.yml (for job6HudiSparkDdlOthersWildcardSuites)
```
Also this doesn't look to be in sync for now:
https://github.com/apache/hudi/blob/83972bd21283ef7c9b689e246c7873c92cb2e5fb/azure-pipelines-20230430.yml#L70-L82
These 3 are not found in the `azure-pipelines-20230430.yml`
```
"org.apache.spark.sql.hudi.dml",
"org.apache.spark.sql.hudi.feature",
"org.apache.spark.sql.hudi.procedure"
```
Let's also add this callout into the PR description
##########
hudi-spark-datasource/hudi-spark-common/src/test/scala/org/apache/spark/sql/hudi/common/TestProvidesHoodieConfig.scala:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
-package org.apache.spark.sql.hudi
+package org.apache.spark.sql.hudi.common
Review Comment:
CMIIW, this test is moved under`common` for consistency right? The changes in `TestSparkSqlHudiPackageStructure` ensures that all test-classes under `ALLOWED_PACKAGES` are tested?
Am asking because of `ProvidesHoodieConfig` and `TestProvidesHoodieConfig` are now living under different hierarchies and wanted to check if this is intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3591043921
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14381:
URL: https://github.com/apache/hudi/pull/14381#discussion_r2573142634
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestSparkSqlHudiPackageStructure.java:
##########
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * Validates that Scala test classes under org.apache.spark.sql.hudi are only in allowed packages.
+ * This ensures proper package structure for CI wildcard suite configurations.
+ * Only Scala test classes are checked; Java test classes are excluded.
+ */
+public class TestSparkSqlHudiPackageStructure {
+
+ private static final String BASE_PACKAGE = "org.apache.spark.sql.hudi";
+ private static final String PACKAGE_PATH = "org/apache/spark/sql/hudi";
+
+ /**
+ * Allowed sub-packages under org.apache.spark.sql.hudi for Scala test classes.
+ * These are referenced in azure-pipelines configuration for wildcard test suites.
Review Comment:
I'll update the docs. The tests in the following three packages are executed separately in Azure CI. The validation guarantees that there should be no test class directly under the package `org.apache.spark.sql.hudi`.
```
"org.apache.spark.sql.hudi.dml",
"org.apache.spark.sql.hudi.feature",
"org.apache.spark.sql.hudi.procedure"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3590900717
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
}, {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14381:
URL: https://github.com/apache/hudi/pull/14381#discussion_r2573142634
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestSparkSqlHudiPackageStructure.java:
##########
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * Validates that Scala test classes under org.apache.spark.sql.hudi are only in allowed packages.
+ * This ensures proper package structure for CI wildcard suite configurations.
+ * Only Scala test classes are checked; Java test classes are excluded.
+ */
+public class TestSparkSqlHudiPackageStructure {
+
+ private static final String BASE_PACKAGE = "org.apache.spark.sql.hudi";
+ private static final String PACKAGE_PATH = "org/apache/spark/sql/hudi";
+
+ /**
+ * Allowed sub-packages under org.apache.spark.sql.hudi for Scala test classes.
+ * These are referenced in azure-pipelines configuration for wildcard test suites.
Review Comment:
I'll update the docs. The tests in the following three packages are executed separately in Azure CI. The validation guarantees that there should be no Scala test class directly under the package `org.apache.spark.sql.hudi`.
```
"org.apache.spark.sql.hudi.dml",
"org.apache.spark.sql.hudi.feature",
"org.apache.spark.sql.hudi.procedure"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #14381:
URL: https://github.com/apache/hudi/pull/14381#discussion_r2573452716
##########
hudi-spark-datasource/hudi-spark-common/src/test/scala/org/apache/spark/sql/hudi/common/TestProvidesHoodieConfig.scala:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
-package org.apache.spark.sql.hudi
+package org.apache.spark.sql.hudi.common
Review Comment:
Got it as long as this is intended, all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3649733114
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
}, {
"hash" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
* 6b75fe9ea97648abb66287683f1b82e16cfe000c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3588125861
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fecdd97c608e78cf174b1c81f19d1bb11c9369e3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3649734334
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
}, {
"hash" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10210",
"triggerID" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
* 6b75fe9ea97648abb66287683f1b82e16cfe000c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10210)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3591043023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3588120784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fecdd97c608e78cf174b1c81f19d1bb11c9369e3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14381:
URL: https://github.com/apache/hudi/pull/14381#discussion_r2573142990
##########
hudi-spark-datasource/hudi-spark-common/src/test/scala/org/apache/spark/sql/hudi/common/TestProvidesHoodieConfig.scala:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
-package org.apache.spark.sql.hudi
+package org.apache.spark.sql.hudi.common
Review Comment:
As I mentioned in the other comment, the Scala test classes directly under `org.apache.spark.sql.hudi` are not executed in Azure CI, so I move them to `org.apache.spark.sql.hudi.common`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3590898533
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
}, {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fecdd97c608e78cf174b1c81f19d1bb11c9369e3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756)
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3590895283
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756",
"triggerID" : "fecdd97c608e78cf174b1c81f19d1bb11c9369e3",
"triggerType" : "PUSH"
}, {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fecdd97c608e78cf174b1c81f19d1bb11c9369e3 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9756)
* 83972bd21283ef7c9b689e246c7873c92cb2e5fb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14381:
URL: https://github.com/apache/hudi/pull/14381#issuecomment-3649792507
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9767",
"triggerID" : "83972bd21283ef7c9b689e246c7873c92cb2e5fb",
"triggerType" : "PUSH"
}, {
"hash" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10210",
"triggerID" : "6b75fe9ea97648abb66287683f1b82e16cfe000c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b75fe9ea97648abb66287683f1b82e16cfe000c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10210)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: Add validation on Spark SQL test classes and fix package structure [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #14381:
URL: https://github.com/apache/hudi/pull/14381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org