You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/04/09 20:46:30 UTC

[GitHub] [accumulo] ivakegg commented on a change in pull request #1082: Improve FateConcurrencyIT to reduce transient test errors (Issue #1079).

ivakegg commented on a change in pull request #1082: Improve FateConcurrencyIT to reduce transient test errors (Issue #1079).
URL: https://github.com/apache/accumulo/pull/1082#discussion_r273692420
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/functional/FateConcurrencyIT.java
 ##########
 @@ -220,7 +225,15 @@ public void getFateStatus() {
 
     Future<?> compactTask = startCompactTask();
 
-    assertTrue("compaction fate transaction exits", findFate(tableName));
+    try {
+
+      assertTrue("compaction fate transaction exits", findFate(tableName));
 
 Review comment:
   The blockUntilCompactionsRunning() essentially does this test.  Perhaps that should return a boolean as to whether a compaction was found and that should be tested instead of depending on the timing of the compaction start on 226.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services