[GitHub] nifi pull request #1045: NIFI-1458: Added ScriptedReportingTask

[alopresto <gi...@git.apache.org>]

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1045#discussion_r83522194
  
    --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptUtils.java ---
    @@ -46,23 +44,19 @@
     import javax.script.ScriptEngineManager;
     import javax.script.ScriptException;
     
    -import org.apache.nifi.annotation.lifecycle.OnStopped;
     import org.apache.nifi.components.AllowableValue;
     import org.apache.nifi.components.PropertyDescriptor;
     import org.apache.nifi.components.ValidationContext;
     import org.apache.nifi.components.ValidationResult;
     import org.apache.nifi.components.Validator;
    -import org.apache.nifi.processor.AbstractSessionFactoryProcessor;
     import org.apache.nifi.processor.Relationship;
     import org.apache.nifi.processor.util.StandardValidators;
     import org.apache.nifi.util.StringUtils;
     
     /**
    - * This class contains variables and methods common to scripting processors
    + * This class contains variables and methods common to scripting processors, reporting tasks, etc.
      */
    -@Stateful(scopes = {Scope.LOCAL, Scope.CLUSTER},
    -        description = "Scripts can store and retrieve state using the State Management APIs. Consult the State Manager section of the Developer's Guide for more details.")
    -public abstract class AbstractScriptProcessor extends AbstractSessionFactoryProcessor {
    +public class ScriptUtils {
    --- End diff --
    
    I'm a little confused -- it seems like this class both contains static constants and utility methods (which I would expect to be together) as well acting as a state container for dynamic values necessary for the `ExecuteScript` or `InvokeScriptedProcessor` components. Am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---