You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 19:11:40 UTC
[GitHub] [arrow] ovr opened a new pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…
ovr opened a new pull request #9163:
URL: https://github.com/apache/arrow/pull/9163
… GROUP BY
Hello!
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758272774
BTW @ovr I am not sure what type you were grouping on, but I had started working on support for String dictionary support for grouping but have gotten distracted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ovr commented on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY
Posted by GitBox <gi...@apache.org>.
ovr commented on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758591304
@alamb I think this problem caused with our fork and Float support, I've prepared a PR with support for Float32/Float64 https://github.com/apache/arrow/pull/9175
But anyway, it's better to get an error message with details which type is not supported, instead of trying to understand it from SQL and DB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ovr commented on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY
Posted by GitBox <gi...@apache.org>.
ovr commented on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758269792
Thanks, @andygrove, for the notice. I've updated the description, and I will use a more useful description in my PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758249298
Hi @ovr could you write a more description PR description? The PR description becomes the commit message when the PR is merged so we want it to explain exactly what the change is/was. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9163:
URL: https://github.com/apache/arrow/pull/9163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758202435
https://issues.apache.org/jira/browse/ARROW-11209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove edited a comment on pull request #9163: ARROW-11209: [Rust] DF - Provider better error message on unsupported…
Posted by GitBox <gi...@apache.org>.
andygrove edited a comment on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758249298
Hi @ovr could you write a more descriptive PR description? The PR description becomes the commit message when the PR is merged so we want it to explain exactly what the change is/was. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb edited a comment on pull request #9163: ARROW-11209: [Rust] DF - Better error message on unsupported GROUP BY
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #9163:
URL: https://github.com/apache/arrow/pull/9163#issuecomment-758272774
BTW @ovr I am not sure what type you were grouping on, but I had started working on support for String dictionary support for grouping but have gotten distracted. Just FYI -- please don't feel like you need to change what you are working on I just wanted to throw that out there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org