You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "swuferhong (via GitHub)" <gi...@apache.org> on 2025/10/30 05:55:00 UTC
[PR] [hotfix] Fix no value present exception when get table bucket leader in LogFetcher [fluss]
swuferhong opened a new pull request, #1897:
URL: https://github.com/apache/fluss/pull/1897
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
<!-- What is the purpose of the change -->
This pr is aims to fix the `NoSuchElementException` throw at client when upgrading cluster:
<img width="1840" height="1126" alt="image" src="https://github.com/user-attachments/assets/7320c9ef-eeaa-498f-8b54-5b4840b4a363" />
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][client] Fix potential metadata inconsistency by deduplicating getBucketLocation call [fluss]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 merged PR #1897:
URL: https://github.com/apache/fluss/pull/1897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix no value present exception when get table bucket leader in LogFetcher [fluss]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #1897:
URL: https://github.com/apache/fluss/pull/1897#discussion_r2476592530
##########
fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogFetcher.java:
##########
@@ -502,8 +503,9 @@ private List<TableBucket> fetchableBuckets() {
}
private Integer getTableBucketLeader(TableBucket tableBucket) {
- if (metadataUpdater.getBucketLocation(tableBucket).isPresent()) {
- BucketLocation bucketLocation = metadataUpdater.getBucketLocation(tableBucket).get();
+ Optional<BucketLocation> bucketLocationOpt = metadataUpdater.getBucketLocation(tableBucket);
Review Comment:
IIUC, here we want to call `metadataUpdater.getBucketLocation` once to make sure the status consistence. Could you change the commit message to `[hotfix][client] Fix potential metadata inconsistency by deduplicating getBucketLocation call` ?
Btw, we can also search similar places in client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][client] Fix potential metadata inconsistency by deduplicating getBucketLocation call [fluss]
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on code in PR #1897:
URL: https://github.com/apache/fluss/pull/1897#discussion_r2476604828
##########
fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogFetcher.java:
##########
@@ -502,8 +503,9 @@ private List<TableBucket> fetchableBuckets() {
}
private Integer getTableBucketLeader(TableBucket tableBucket) {
- if (metadataUpdater.getBucketLocation(tableBucket).isPresent()) {
- BucketLocation bucketLocation = metadataUpdater.getBucketLocation(tableBucket).get();
+ Optional<BucketLocation> bucketLocationOpt = metadataUpdater.getBucketLocation(tableBucket);
Review Comment:
Done! I have checked the callers of MetadataUpdater and confirmed that there are no other inconsistent invocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org