You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/11 05:41:30 UTC
[GitHub] [kafka] highluck opened a new pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
highluck opened a new pull request #10302:
URL: https://github.com/apache/kafka/pull/10302
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-815245190
Merged to trunk, thanks @highluck !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-808940415
I think we should have only one PR -- not sure why you did pick it up Guozhang? The ticket was clearly assigned to @highluck
@highluck -- the ticket is about _removing_ the config completely -- cf @guozhangwang PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-807922328
@mjsax if you can review and merge @highluck 's PR let's do it, I can rebase the other afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809023212
@mjsax
thanks
I've updated the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-811718022
@guozhangwang
thanks review
@mjsax ping
Sorry to be busy, but please review! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-806209047
Seems like we have two seemingly identical tickets & PRs for this -- https://github.com/apache/kafka/pull/10380
cc @guozhangwang @highluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-813824311
@guozhangwang
May I ask for a merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #10302:
URL: https://github.com/apache/kafka/pull/10302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-796472222
@mjsax
Would this be what you want?
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809005491
@highluck Feel free to proceed (it would be somewhat double work, but I don't want to "take it away" from you). Happy to merge your PR instead of Guozhang's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper
Posted by GitBox <gi...@apache.org>.
highluck commented on pull request #10302:
URL: https://github.com/apache/kafka/pull/10302#issuecomment-809003963
@mjsax
If so, can I proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org