You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Boris Zhu <zh...@gmail.com> on 2019/11/27 01:16:13 UTC
Who can review this pr?
Hi,
Can someone help me with reviewing this pr?
https://github.com/apache/incubator-iotdb/pull/564
Best
Boris
AW: Who can review this pr?
Posted by Christofer Dutz <ch...@c-ware.de>.
And IMHO using antlr4 is way simpler, resulting in better maintained usage of antlr.
Usually the antlr2 or 3 part of a project is the part none wants to touch ;-)
So a general +1 for that
Chris
________________________________
Von: Boris Zhu <zh...@gmail.com>
Gesendet: Mittwoch, 27. November 2019 03:19:10
An: dev@iotdb.apache.org <de...@iotdb.apache.org>
Betreff: Re: Who can review this pr?
It is about upgrading antlr3 to antlr4, I don't think it's a good idea to
use a software that is no longer maintained.
On Wed, Nov 27, 2019 at 9:16 AM Boris Zhu <zh...@gmail.com> wrote:
> Hi,
> Can someone help me with reviewing this pr?
> https://github.com/apache/incubator-iotdb/pull/564
>
> Best
> Boris
>
Re: Who can review this pr?
Posted by Lei Rui <ne...@163.com>.
Agree. The plugin for Antlr4 in IDEA is really easy to use. Thank you for your work.
I can review this pr this week.
Lei Rui
On 11/27/2019 10:19，Boris Zhu<zh...@gmail.com> wrote：
It is about upgrading antlr3 to antlr4, I don't think it's a good idea to
use a software that is no longer maintained.
On Wed, Nov 27, 2019 at 9:16 AM Boris Zhu <zh...@gmail.com> wrote:
Hi,
Can someone help me with reviewing this pr?
https://github.com/apache/incubator-iotdb/pull/564
Best
Boris
Re: Who can review this pr?
Posted by Boris Zhu <zh...@gmail.com>.
It is about upgrading antlr3 to antlr4, I don't think it's a good idea to
use a software that is no longer maintained.
On Wed, Nov 27, 2019 at 9:16 AM Boris Zhu <zh...@gmail.com> wrote:
> Hi,
> Can someone help me with reviewing this pr?
> https://github.com/apache/incubator-iotdb/pull/564
>
> Best
> Boris
>