You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/08/14 07:24:21 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11341: Add new broker query point for querying multi-stage engine
xiangfu0 opened a new pull request, #11341:
URL: https://github.com/apache/pinot/pull/11341
Per #11251 , create two new Broker API endpoints for multi-stage query engine.
```
GET /query
POST /query
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11341: Add new broker query point for querying multi-stage engine
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11341:
URL: https://github.com/apache/pinot/pull/11341#discussion_r1293084830
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -169,6 +170,78 @@ public void processSqlQueryPost(String query, @Suspended AsyncResponse asyncResp
}
}
+ @GET
+ @ManagedAsync
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("query")
+ @ApiOperation(value = "Querying pinot using MultiStage Query Engine")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Query response"),
+ @ApiResponse(code = 500, message = "Internal Server Error")
+ })
+ @ManualAuthorization
+ public void processSqlWithMultiStageQueryEngineGet(
+ @ApiParam(value = "Query", required = true) @QueryParam("sql") String query,
+ @ApiParam(value = "Trace enabled") @QueryParam(Request.TRACE) String traceEnabled,
+ @ApiParam(value = "Debug options") @QueryParam(Request.DEBUG_OPTIONS) String debugOptions,
Review Comment:
Debug options is already deprecated. Let's not add them in the new API.
For `trace`, I'm not sure if it can be added as a query option. If so, we can also remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11341: Add new broker query point for querying multi-stage engine
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11341:
URL: https://github.com/apache/pinot/pull/11341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #11341: Add new broker query point for querying multi-stage engine
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11341:
URL: https://github.com/apache/pinot/pull/11341#issuecomment-1679432186
Please add these new APIs to the pinot doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11341: Add new broker query point for querying multi-stage engine
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #11341:
URL: https://github.com/apache/pinot/pull/11341#discussion_r1293086700
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -169,6 +170,78 @@ public void processSqlQueryPost(String query, @Suspended AsyncResponse asyncResp
}
}
+ @GET
+ @ManagedAsync
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("query")
+ @ApiOperation(value = "Querying pinot using MultiStage Query Engine")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Query response"),
+ @ApiResponse(code = 500, message = "Internal Server Error")
+ })
+ @ManualAuthorization
+ public void processSqlWithMultiStageQueryEngineGet(
+ @ApiParam(value = "Query", required = true) @QueryParam("sql") String query,
+ @ApiParam(value = "Trace enabled") @QueryParam(Request.TRACE) String traceEnabled,
+ @ApiParam(value = "Debug options") @QueryParam(Request.DEBUG_OPTIONS) String debugOptions,
Review Comment:
removed both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11341: Add new broker query point for querying multi-stage engine
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11341:
URL: https://github.com/apache/pinot/pull/11341#issuecomment-1676920394
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11341](https://app.codecov.io/gh/apache/pinot/pull/11341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1e614e2) into [master](https://app.codecov.io/gh/apache/pinot/commit/f25f3ed1f242513b90207d082fb80dbfdc9b06f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f25f3ed) will **decrease** coverage by `38.35%`.
> Report is 2 commits behind head on master.
> The diff coverage is `27.27%`.
```diff
@@ Coverage Diff @@
## master #11341 +/- ##
=============================================
- Coverage 68.46% 30.12% -38.35%
+ Complexity 6535 495 -6040
=============================================
Files 2233 2233
Lines 119952 119985 +33
Branches 18191 18193 +2
=============================================
- Hits 82128 36143 -45985
- Misses 31984 80556 +48572
+ Partials 5840 3286 -2554
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `20.97% <27.27%> (-0.02%)` | :arrow_down: |
| integration2 | `?` | |
| java-11 | `29.99% <27.27%> (-38.43%)` | :arrow_down: |
| java-17 | `29.98% <27.27%> (-38.33%)` | :arrow_down: |
| java-20 | `30.00% <27.27%> (-38.29%)` | :arrow_down: |
| temurin | `30.12% <27.27%> (-38.35%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `14.65% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pinot/broker/api/resources/PinotClientRequest.java](https://app.codecov.io/gh/apache/pinot/pull/11341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdENsaWVudFJlcXVlc3QuamF2YQ==) | `29.90% <27.27%> (-16.04%)` | :arrow_down: |
... and [1360 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11341/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org