You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "XiaoXiang Yu (JIRA)" <ji...@apache.org> on 2018/09/25 01:29:00 UTC
[jira] [Updated] (KYLIN-3578) Do not synchronize on the intrinsic
locks of high-level concurrency objects
[ https://issues.apache.org/jira/browse/KYLIN-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
XiaoXiang Yu updated KYLIN-3578:
--------------------------------
Fix Version/s: v2.6.0
> Do not synchronize on the intrinsic locks of high-level concurrency objects
> ---------------------------------------------------------------------------
>
> Key: KYLIN-3578
> URL: https://issues.apache.org/jira/browse/KYLIN-3578
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: XiaoXiang Yu
> Priority: Major
> Fix For: v2.6.0
>
>
> From core-common/src/main/java/org/apache/kylin/common/util/MemoryBudgetController.java :
> {code}
> private final ReentrantLock lock = new ReentrantLock();
> ...
> synchronized (lock) {
> {code}
> See the following for why such practice is to be avoided:
> https://wiki.sei.cmu.edu/confluence/display/java/LCK03-J.+Do+not+synchronize+on+the+intrinsic+locks+of+high-level+concurrency+objects
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)