You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/09/01 21:16:18 UTC

[GitHub] [airflow] jedcunningham commented on issue #20421: Inconsistencies in Pod labels after AIP-39

jedcunningham commented on issue #20421:
URL: https://github.com/apache/airflow/issues/20421#issuecomment-1703327722

   They don't have to be, but I'd say the "core" labels that associate it with a task would make a lot of sense to keep consistent (basically, the TI pk labels).
   
   [KPO side](https://github.com/apache/airflow/blob/3ae6b4e86fe807c00bd736c59df58733df2b9bf9/airflow/providers/cncf/kubernetes/operators/pod.py#L483-L488) vs [KE side](https://github.com/apache/airflow/blob/3ae6b4e86fe807c00bd736c59df58733df2b9bf9/airflow/providers/cncf/kubernetes/pod_generator.py#L415-L416) - The latter today has both execution_date and run_id.
   
   Not sure when KE got the run_id, but I see these "core" labels on both sides now, so I think we are good to close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org