You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GJL <gi...@git.apache.org> on 2018/02/07 11:34:09 UTC

[GitHub] flink pull request #5422: [FLINK-8575][runtime] BackPressureStatsTrackerITCa...

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5422

    [FLINK-8575][runtime] BackPressureStatsTrackerITCase unstable

    ## What is the purpose of the change
    
    *This fixes BackPressureStatsTrackerITCase unstability.*
    
    
    ## Brief change log
    
      - *Add missing synchronization in BackPressureStatsTracker. Operations in method getOperatorBackPressureStats must appear atomic otherwise the stack trace can be sampled multiple times.*
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *BackPressureStatsTrackerITCase*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-8575

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5422
    
----
commit 8c2b005b90631f7dd818a5d8a06400d5cebc83d7
Author: gyao <ga...@...>
Date:   2018-02-07T11:25:35Z

    [FLINK-8575][runtime] Add missing synchronization in BackPressureStatsTracker
    
    Operations in method getOperatorBackPressureStats must appear atomic otherwise
    the stack trace can be sampled multiple times.

----


---

[GitHub] flink pull request #5422: [FLINK-8575][runtime] BackPressureStatsTrackerITCa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5422


---