[GitHub] [airflow] mik-laj commented on a change in pull request #12657: Add possibility to configure upgrade_check command

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #12657:
URL: https://github.com/apache/airflow/pull/12657#discussion_r532009028



##########
File path: airflow/upgrade/config.py
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import absolute_import
+import yaml
+
+from airflow.utils.module_loading import import_string
+
+
+class UpgradeConfig(object):
+    def __init__(self, raw_config):
+        self._raw_config = raw_config
+
+    def remove_ignored_rules(self, rules):
+        rules_to_ignore = self._raw_config.get("ignored_rules")
+        if not rules_to_ignore:
+            return rules
+        return [r for r in rules if r.__class__.__name__ not in rules_to_ignore]
+
+    def register_custom_rules(self, rules):
+        custom_rules = self._raw_config.get("custom_rules")
+        if not custom_rules:
+            return rules
+        for custom_rule in custom_rules:
+            rule = import_string(custom_rule)
+            rules.append(rule())
+        return rules
+
+    @classmethod
+    def read(cls, path):
+        with open(path) as f:
+            raw_config = yaml.safe_load(f)

Review comment:
       Can you add JSON Schema validation? We accept user data here, so we cannot trust this data to be correct, so we should validate it.
   ```json
   {
     "$schema": "http://json-schema.org/draft-04/schema#",
     "type": "object",
     "properties": {
       "ignored_rules": {
         "type": "array",
         "items": {
           "type": "string"
         }
       },
       "custom_rules": {
         "type": "array",
         "items": {
           "type": "string"
         }
       }
     },
     "additionalProperties": false
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org