You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/17 00:05:03 UTC

[GitHub] [iceberg] omaraloraini edited a comment on pull request #2336: Reduce boxing in ParquetValueReaders.StructReader

omaraloraini edited a comment on pull request #2336:
URL: https://github.com/apache/iceberg/pull/2336#issuecomment-800687074


   Hi Ryan, what kind of benchmark fits here? JMH? or should I run one on our jobs(at work)?
   I did a profiling run to validate the change, and as far as I can tell it seems it does the right thing.
   ![before](https://user-images.githubusercontent.com/5780138/111393621-20fe8900-86ca-11eb-8c68-4976478a6cc0.png)
   ![after](https://user-images.githubusercontent.com/5780138/111393626-23f97980-86ca-11eb-9789-c9830d16291e.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org