You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "austenstone (via GitHub)" <gi...@apache.org> on 2026/10/12 03:35:58 UTC
[PR] Run shared distribution tests in a single CI job [airflow]
austenstone opened a new pull request, #74566:
URL: https://github.com/apache/airflow/pull/74566
Every PR starts 14 separate ~20s "Shared <dist> tests" jobs, using 14 of the 20 concurrent jobs ASF allows per workflow. Last week that was about 1 in 5 jobs in Tests (AMD), mostly spent on checkout and uv setup rather than tests.
This runs the shared distributions sequentially in one job, each in its own log group, and fails with a list of every distribution that failed. The 14 per-distribution checks become one "Shared distributions tests" check; none were required.
Verified with actionlint, shellcheck and zizmor; locally the loop passes all 14 distributions in ~66s and reports failures by name.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (GitHub Copilot, Claude Opus 5.5)
Generated-by: GitHub Copilot (Claude Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run shared distribution tests in a single CI job [airflow]
Posted by "Andrushika (via GitHub)" <gi...@apache.org>.
Andrushika commented on code in PR #74566:
URL: https://github.com/apache/airflow/pull/74566#discussion_r4245482015
##########
.github/workflows/basic-tests.yml:
##########
@@ -152,9 +149,18 @@ jobs:
fi
echo "Installing uv==${UV_VERSION}"
pip install "uv==${UV_VERSION}"
- - name: "Run shared ${{ matrix.shared-distribution }} tests"
- run: uv run --group dev pytest --color=yes -n auto
- working-directory: shared/${{ matrix.shared-distribution }}
+ - name: "Run shared distributions tests"
+ run: |
+ failed=()
+ for dist in ${SHARED_DISTRIBUTIONS}; do
+ echo "::group::Shared ${dist} tests"
+ (cd "shared/${dist}" && uv run --group dev pytest --color=yes -n auto) || failed+=("${dist}")
Review Comment:
We need "isolation" here. Otherwise, even if a dependency is missing from `pyproject.toml`, the check can't detect it.
`--exact` removes the packages the current distribution does not declare, so a missing dependency fails the run again.
```suggestion
(cd "shared/${dist}" && uv run --exact --group dev pytest --color=yes -n auto) || failed+=("${dist}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run shared distribution tests in a single CI job [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #74566:
URL: https://github.com/apache/airflow/pull/74566#issuecomment-6254842402
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run shared distribution tests in a single CI job [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #74566:
URL: https://github.com/apache/airflow/pull/74566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run shared distribution tests in a single CI job [airflow]
Posted by "austenstone (via GitHub)" <gi...@apache.org>.
austenstone commented on code in PR #74566:
URL: https://github.com/apache/airflow/pull/74566#discussion_r4251276711
##########
.github/workflows/basic-tests.yml:
##########
@@ -152,9 +149,18 @@ jobs:
fi
echo "Installing uv==${UV_VERSION}"
pip install "uv==${UV_VERSION}"
- - name: "Run shared ${{ matrix.shared-distribution }} tests"
- run: uv run --group dev pytest --color=yes -n auto
- working-directory: shared/${{ matrix.shared-distribution }}
+ - name: "Run shared distributions tests"
+ run: |
+ failed=()
+ for dist in ${SHARED_DISTRIBUTIONS}; do
+ echo "::group::Shared ${dist} tests"
+ (cd "shared/${dist}" && uv run --group dev pytest --color=yes -n auto) || failed+=("${dist}")
Review Comment:
Applied: each shared dist now runs `uv run --exact`, so a dependency missing from its `pyproject.toml` fails the check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run shared distribution tests in a single CI job [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #74566:
URL: https://github.com/apache/airflow/pull/74566#issuecomment-6117278189
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org