You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/19 05:57:13 UTC

[GitHub] [pulsar] jerrypeng commented on issue #9966: Fail immediately on ErrorNotifierRecord inside BatchPushSource

jerrypeng commented on issue #9966:
URL: https://github.com/apache/pulsar/issues/9966#issuecomment-802578589


   > When an IO connector that implements the BatchPushSource interface wants to fail a task, it publishes a ErrorNotifierRecord to the internal queue. However, the exception isn't thrown until the readNext method reads the message from the internal queue.
   
   This is done intentionally so messages that were already consumed will still get a chance to be published.
   
   > In addition, a lot of records are processed that shouldn't be
   
   In what scenario will records get processed that shouldn't be processed?  The ErrorNotifierRecord is sent in stream, thus messages that came before it should be valid messages that can be sent out.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org