You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/15 09:22:03 UTC
[GitHub] [incubator-echarts] wf123537200 opened a new pull request #13285: feat(tooltip): add formatter cache to tooltip
wf123537200 opened a new pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285
move [PR 12504](https://github.com/apache/incubator-echarts/pull/12504) to ```next``` branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285#issuecomment-692588699
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285#issuecomment-706845274
I'm not sure if we need to put this cache logic inside echarts. The caching strategy heavily depends(for example how to compose the key) on the business logic on the top. And it's not so complex to be implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] wf123537200 closed pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
wf123537200 closed pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285#issuecomment-706845274
I'm not sure if we need to put this cache logic inside echarts. The caching strategy heavily depends on the business logic on the top. And it's not so complex to be implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] wf123537200 commented on pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
wf123537200 commented on pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285#issuecomment-709057426
> I'm not sure if we need to put this cache logic inside echarts. The caching strategy(for example how to compose the key) heavily depends on the business logic on the top. And it's not so complex to be implemented.
Maybe you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13285: feat(tooltip): add formatter cache to tooltip
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13285:
URL: https://github.com/apache/incubator-echarts/pull/13285#issuecomment-706845274
I'm not sure if we need to put this cache logic inside echarts. The caching strategy(for example how to compose the key) heavily depends on the business logic on the top. And it's not so complex to be implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org