You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 08:37:10 UTC

[GitHub] [flink] twalthr commented on pull request #11862: [FLINK-17251] [table] supports INSERT statement in TableEnvironment#executeSql and Table#executeInsert api

twalthr commented on pull request #11862:
URL: https://github.com/apache/flink/pull/11862#issuecomment-625113888


   @godfreyhe thanks for the explanation. For the future, we should start documenting our thoughts in the code for other contributors. A comment like `once old planner is removed, TableEnvironmentInternal also can be removed.` would be helpful in this class. I have no further concerns.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org