You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/19 14:32:47 UTC
[GitHub] [shardingsphere] huangdx0726 opened a new pull request, #20309: Extract list() method to PipelineJobPublicAPI and AbstractPipelineJobAPIImpl for common usage
huangdx0726 opened a new pull request, #20309:
URL: https://github.com/apache/shardingsphere/pull/20309
…APIImpl for common usage
Fixes #20298 .
Changes proposed in this pull request:
-
- Extract list() method to PipelineJobPublicAPI and AbstractPipelineJobAPIImpl for common usage
- Add abstract class PipelineJobInfo; Add sub-class MigrationJobInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20309: Extract list() method to PipelineJobPublicAPI and AbstractPipelineJobAPIImpl for common usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20309:
URL: https://github.com/apache/shardingsphere/pull/20309#issuecomment-1220799930
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20309](https://codecov.io/gh/apache/shardingsphere/pull/20309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86ec388) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c1c5957e7796a4e9872a11228c443e85eea9f0cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1c5957) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #20309 +/- ##
============================================
- Coverage 60.94% 60.93% -0.01%
Complexity 2439 2439
============================================
Files 3895 3896 +1
Lines 54867 54870 +3
Branches 9330 9331 +1
============================================
Hits 33436 33436
- Misses 18573 18576 +3
Partials 2858 2858
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...phere/data/pipeline/api/pojo/MigrationJobInfo.java](https://codecov.io/gh/apache/shardingsphere/pull/20309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL3Bvam8vTWlncmF0aW9uSm9iSW5mby5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...line/core/api/impl/AbstractPipelineJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/20309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvYXBpL2ltcGwvQWJzdHJhY3RQaXBlbGluZUpvYkFQSUltcGwuamF2YQ==) | `5.79% <0.00%> (-0.66%)` | :arrow_down: |
| [...phere/data/pipeline/core/job/FinishedCheckJob.java](https://codecov.io/gh/apache/shardingsphere/pull/20309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvam9iL0ZpbmlzaGVkQ2hlY2tKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...peline/scenario/migration/MigrationJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/20309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL21pZ3JhdGlvbi9NaWdyYXRpb25Kb2JBUElJbXBsLmphdmE=) | `1.95% <0.00%> (+0.05%)` | :arrow_up: |
| [...ine/scenario/rulealtered/RuleAlteredJobWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/20309/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iV29ya2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #20309: Extract list() method to PipelineJobPublicAPI and AbstractPipelineJobAPIImpl for common usage
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #20309:
URL: https://github.com/apache/shardingsphere/pull/20309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org