You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2018/03/15 20:43:05 UTC
[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2556
NIFI-4981 - Allow using FF's content as message in PutEmail
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-4981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2556
----
commit 56fb6b87532e1185b927803f6914417800deb5c1
Author: Pierre Villard <pi...@...>
Date: 2018-03-15T18:28:26Z
NIFI-4981 - Allow using FF's content as message in PutEmail
----
---
[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2556#discussion_r175285317
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java ---
@@ -194,6 +200,15 @@
.allowableValues("true", "false")
.defaultValue("false")
.build();
+ public static final PropertyDescriptor CONTENT_AS_MESSAGE = new PropertyDescriptor.Builder()
--- End diff --
Good point. Fixed.
---
[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2556
---
[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/2556
+1 Looks good to me. Thank you @pvillard31 :)
---
[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2556
Reviewing
---
[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2556
LGTM:
* Full build passes
* Good use of SystemResourceConsideration for memory consideration
* Good test coverage
* PutEmail worked correctly in my testing with various content option combinations
Thanks @pvillard31 and @zenfenan!
---
[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2556#discussion_r175278665
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java ---
@@ -194,6 +200,15 @@
.allowableValues("true", "false")
.defaultValue("false")
.build();
+ public static final PropertyDescriptor CONTENT_AS_MESSAGE = new PropertyDescriptor.Builder()
--- End diff --
With this, we can set `MESSAGE.required()` can be set to `false`, right?
---