You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/05/04 08:48:17 UTC

[GitHub] [zeppelin] KirillTurchinskii opened a new pull request #3760: Minor refactoring

KirillTurchinskii opened a new pull request #3760:
URL: https://github.com/apache/zeppelin/pull/3760


   ### What is this PR for?
   Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false.
   Then I will move to annotations and other issues that my static analyzer shows
   (My previous branch was removed because of the multiple problems, so I decided to start over)
   
   
   ### What type of PR is it?
   Refactoring
   
   ### What is the Jira issue?
   This task is not on jira, but I'll move to this
   https://issues.apache.org/jira/browse/ZEPPELIN-3225?filter=12348928
   
   ### How should this be tested?
   https://travis-ci.org/github/KirillTurchinskii/zeppelin/builds/682716706
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * What else besides annotations (that I will add) I can fix/refactor using static analysis?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] Reamer commented on pull request #3760: Minor refactoring

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3760:
URL: https://github.com/apache/zeppelin/pull/3760#issuecomment-623556924


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] Leemoonsoo commented on pull request #3760: Minor refactoring

Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3760:
URL: https://github.com/apache/zeppelin/pull/3760#issuecomment-624706308


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org