[GitHub] [calcite] zabetak commented on a change in pull request #884: [CALCITE-2621] New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) (Ruben Quesada Lopez)

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #884: [CALCITE-2621] New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/884#discussion_r262009392
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
 ##########
 @@ -56,31 +60,57 @@
  *
  * <p>would require emitting a NULL emp row if a certain department contained no
  * employees, and Correlator cannot do that.</p>
+ *
+ * <p>There is a constructor parameterized to allow any sub-class of
+ * {@link org.apache.calcite.rel.core.Join}, not just
+ * {@link org.apache.calcite.rel.logical.LogicalJoin}.</p>
  */
 public class JoinToCorrelateRule extends RelOptRule {
+
+  private final Function<Join, SemiJoinType> semiJoinTypeFunction;
+
   //~ Static fields/initializers ---------------------------------------------
 
   public static final JoinToCorrelateRule INSTANCE =
 
 Review comment:
   I am afraid I was bit hasty, sorry for that. In order not too break backward compatibility let's also keep INSTANCE and mark it as deprecated with a pointer to JOIN. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services